NAK: [PATCH 0/2][Xenial SRU] UBUNTU: SAUCE: lng2dm 3-axis accelerometer support

Shrirang Bagul shrirang.bagul at canonical.com
Fri Dec 16 04:46:57 UTC 2016


I did consider fetching all the the updates, but felt that the amount of changes
to the st_sensors common code was too much just to support one sensor. Another
reason is that we don't have the hardware to test for regressions that these
updates might introduce for sensors other than lng2dm. Although, it was a
mistake marking the patch as "cherry picked" when certainly its a "backport".

I'll pull the patches as per your suggestion and test it on the HW we have
before submitting them again.

-Shrirang

On Thu, 2016-12-15 at 07:19 -0700, Tim Gardner wrote:
> Patch 1 isn't even close to a clean cherry-pick, nor is the source as
> noted in the commit log. Have you considered fetching all of the updates
> to that sensor driver ?
> 
> The following changes since commit 0885e08ead1b16fd6f9cbe6641082dac04a1ca64:
> 
>   xen/qspinlock: Don't kick CPU if IRQ is not initialized (2016-12-15
> 10:07:13 +0000)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/rtg/ubuntu-xenial.git st-accel
> 
> for you to fetch changes up to bb0016c47b97265931c5ed0b988dec80efb32fa7:
> 
>   Documentation: dt: iio: accel: add lng2dm sensor device binding
> (2016-12-15 07:14:03 -0700)
> 
> ----------------------------------------------------------------
> Giuseppe Barba (1):
>       iio: st-accel: add support for lis2dh12
> 
> Gregor Boirie (1):
>       iio:st_sensors: fix power regulator usage
> 
> Jonathan Cameron (1):
>       iio: accel: st_accel: Add lis3l02dq support
> 
> Linus Walleij (5):
>       iio: st_sensors: support active-low interrupts
>       iio: st_sensors: verify interrupt event to status
>       iio: st_sensors: support open drain mode
>       iio: st_sensors: switch to a threaded interrupt
>       iio: accel: st_accel: inline per-sensor data
> 
> Lorenzo Bianconi (3):
>       iio: st_sensors: fix scale configuration for h3lis331dl
>       iio: accel: st_accel: add support to lng2dm
>       Documentation: dt: iio: accel: add lng2dm sensor device binding
> 
> Tiberiu Breana (1):
>       iio: accel: Add support for the h3lis331dl accelerometer
> 
>  Documentation/devicetree/bindings/iio/st-sensors.txt |   7 ++
>  drivers/iio/accel/Kconfig                            |   3 +-
>  drivers/iio/accel/st_accel.h                         |   4 +
>  drivers/iio/accel/st_accel_buffer.c                  |   2 +-
>  drivers/iio/accel/st_accel_core.c                    | 614
> +++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------
> ----------------
>  drivers/iio/accel/st_accel_i2c.c                     |  19 +++
>  drivers/iio/accel/st_accel_spi.c                     |   3 +
>  drivers/iio/common/st_sensors/st_sensors_buffer.c    |   9 +-
>  drivers/iio/common/st_sensors/st_sensors_core.c      |  93 +++++++++++----
>  drivers/iio/common/st_sensors/st_sensors_core.h      |   8 ++
>  drivers/iio/common/st_sensors/st_sensors_trigger.c   | 147
> +++++++++++++++++++++--
>  drivers/iio/gyro/st_gyro_buffer.c                    |   2 +-
>  drivers/iio/gyro/st_gyro_core.c                      |  31 ++++-
>  drivers/iio/magnetometer/st_magn_buffer.c            |   2 +-
>  drivers/iio/magnetometer/st_magn_core.c              |  18 ++-
>  drivers/iio/pressure/st_pressure_buffer.c            |   2 +-
>  drivers/iio/pressure/st_pressure_core.c              |  31 ++++-
>  include/linux/iio/common/st_sensors.h                |  24 +++-
>  include/linux/platform_data/st_sensors_pdata.h       |   2 +
>  19 files changed, 700 insertions(+), 321 deletions(-)
>  create mode 100644 drivers/iio/common/st_sensors/st_sensors_core.h
> 




More information about the kernel-team mailing list