[4.2.y-ckt stable] Patch "mtd: ubi: don't leak e if schedule_erase() fails" has been added to the 4.2.y-ckt tree
    Kamal Mostafa 
    kamal at canonical.com
       
    Fri Jan 15 23:56:58 UTC 2016
    
    
  
This is a note to let you know that I have just added a patch titled
    mtd: ubi: don't leak e if schedule_erase() fails
to the linux-4.2.y-queue branch of the 4.2.y-ckt extended stable tree 
which can be found at:
    http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-4.2.y-queue
This patch is scheduled to be released in version 4.2.8-ckt2.
If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.
For more information about the 4.2.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
Thanks.
-Kamal
---8<------------------------------------------------------------
>From 9c6019cefc07e89ab9a2c03c432278d3e7189e4b Mon Sep 17 00:00:00 2001
From: Sebastian Siewior <bigeasy at linutronix.de>
Date: Thu, 26 Nov 2015 21:23:49 +0100
Subject: mtd: ubi: don't leak e if schedule_erase() fails
commit 6b238de189f69dc77d660d4cce62eed15547f4c3 upstream.
If __erase_worker() fails to erase the EB and schedule_erase() fails as
well to do anything about it then we go RO. But that is not a reason to
leak the e argument here. Therefore clean up e.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
Signed-off-by: Richard Weinberger <richard at nod.at>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/mtd/ubi/wl.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index f73233f..5606563 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -1060,6 +1060,7 @@ static int __erase_worker(struct ubi_device *ubi, struct ubi_work *wl_wrk)
 		/* Re-schedule the LEB for erasure */
 		err1 = schedule_erase(ubi, e, vol_id, lnum, 0);
 		if (err1) {
+			wl_entry_destroy(ubi, e);
 			err = err1;
 			goto out_ro;
 		}
--
1.9.1
    
    
More information about the kernel-team
mailing list