[SRU][Trusty][PATCH 1/3] sched/numa: Move task_numa_free() to __put_task_struct()
Gavin Guo
gavin.guo at canonical.com
Sat Mar 12 14:09:09 UTC 2016
From: Mike Galbraith <bitbucket at online.de>
BugLink: https://bugs.launchpad.net/bugs/1527643
Bad idea on -rt:
[ 908.026136] [<ffffffff8150ad6a>] rt_spin_lock_slowlock+0xaa/0x2c0
[ 908.026145] [<ffffffff8108f701>] task_numa_free+0x31/0x130
[ 908.026151] [<ffffffff8108121e>] finish_task_switch+0xce/0x100
[ 908.026156] [<ffffffff81509c0a>] thread_return+0x48/0x4ae
[ 908.026160] [<ffffffff8150a095>] schedule+0x25/0xa0
[ 908.026163] [<ffffffff8150ad95>] rt_spin_lock_slowlock+0xd5/0x2c0
[ 908.026170] [<ffffffff810658cf>] get_signal_to_deliver+0xaf/0x680
[ 908.026175] [<ffffffff8100242d>] do_signal+0x3d/0x5b0
[ 908.026179] [<ffffffff81002a30>] do_notify_resume+0x90/0xe0
[ 908.026186] [<ffffffff81513176>] int_signal+0x12/0x17
[ 908.026193] [<00007ff2a388b1d0>] 0x7ff2a388b1cf
and since upstream does not mind where we do this, be a bit nicer ...
Signed-off-by: Mike Galbraith <bitbucket at online.de>
Signed-off-by: Peter Zijlstra <peterz at infradead.org>
Cc: Mel Gorman <mgorman at suse.com>
Cc: Linus Torvalds <torvalds at linux-foundation.org>
Cc: Andrew Morton <akpm at linux-foundation.org>
Cc: Thomas Gleixner <tglx at linutronix.de>
Link: http://lkml.kernel.org/r/1393568591.6018.27.camel@marge.simpson.net
Signed-off-by: Ingo Molnar <mingo at kernel.org>
(backported from commit 156654f491dd8d52687a5fbe1637f472a52ce75b)
Signed-off-by: Gavin Guo <gavin.guo at canonical.com>
Conflicts:
kernel/sched/core.c
---
kernel/fork.c | 1 +
kernel/sched/core.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 52651f1a6a5e..f5e5831b67c3 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -237,6 +237,7 @@ void __put_task_struct(struct task_struct *tsk)
WARN_ON(atomic_read(&tsk->usage));
WARN_ON(tsk == current);
+ task_numa_free(tsk);
security_task_free(tsk);
exit_creds(tsk);
delayacct_tsk_free(tsk);
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 42d354e60c3d..da8f1eab7f17 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2037,7 +2037,6 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev)
if (mm)
mmdrop(mm);
if (unlikely(prev_state == TASK_DEAD)) {
- task_numa_free(prev);
/*
* Remove function-return probe instances associated with this
--
2.0.0
More information about the kernel-team
mailing list