NAK: [Xenial][PULL] Marvell wireless driver update

Kamal Mostafa kamal at canonical.com
Fri May 20 18:54:09 UTC 2016


On Fri, May 20, 2016 at 11:45:03AM -0600, Tim Gardner wrote:
> Kamal - the branch name is marvell

Thanks Tim.

But still NAK, because it results in a pile of compiler warnings:

In file included from .../drivers/net/wireless/mwifiex/sta_cmd.c:24:0:
.../drivers/net/wireless/mwifiex/sta_cmd.c: In function 'mwifiex_cmd_cfg_data':
.../drivers/net/wireless/mwifiex/sta_cmd.c:1533:16: warning: passing argument 1 of '_mwifiex_dbg' from incompatible pointer type [-Wincompatible-pointer-types]
    mwifiex_dbg(adapter->dev, INFO,
                ^
.../drivers/net/wireless/mwifiex/main.h:194:15: note: in definition of macro 'mwifiex_dbg'
  _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__)
               ^
.../drivers/net/wireless/mwifiex/main.h:191:6: note: expected 'const struct mwifiex_adapter *' but argument is of type 'struct device *'
 void _mwifiex_dbg(const struct mwifiex_adapter *adapter, int mask,
      ^
.../drivers/net/wireless/mwifiex/sta_cmd.c:1541:15: warning: passing argument 1 of '_mwifiex_dbg' from incompatible pointer type [-Wincompatible-pointer-types]
   mwifiex_dbg(adapter->dev, INFO, "download cfg_data from iw vendor command\n");
               ^
.../drivers/net/wireless/mwifiex/main.h:194:15: note: in definition of macro 'mwifiex_dbg'
  _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__)
               ^
.../drivers/net/wireless/mwifiex/main.h:191:6: note: expected 'const struct mwifiex_adapter *' but argument is of type 'struct device *'
 void _mwifiex_dbg(const struct mwifiex_adapter *adapter, int mask,
      ^


Jesse, please take another look at this patch set and re-submit.

 -Kamal




More information about the kernel-team mailing list