[PATCH X/Y SRU] scsi: ibmvfc: Fix I/O hang when port is not mapped
Tim Gardner
tim.gardner at canonical.com
Tue Oct 11 15:33:23 UTC 2016
From: Brian King <brking at linux.vnet.ibm.com>
BugLink: http://bugs.launchpad.net/bugs/1632116
If a VFC port gets unmapped in the VIOS, it may not respond with a CRQ
init complete following H_REG_CRQ. If this occurs, we can end up having
called scsi_block_requests and not a resulting unblock until the init
complete happens, which may never occur, and we end up hanging I/O
requests. This patch ensures the host action stay set to
IBMVFC_HOST_ACTION_TGT_DEL so we move all rports into devloss state and
unblock unless we receive an init complete.
Cc: <stable at vger.kernel.org>
Signed-off-by: Brian King <brking at linux.vnet.ibm.com>
Acked-by: Tyrel Datwyler <tyreld at linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
(cherry picked from linux-next commit 07d0e9a847401ffd2f09bd450d41644cd090e81d)
Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 6aa317c..1f9f9e5 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -717,7 +717,6 @@ static int ibmvfc_reset_crq(struct ibmvfc_host *vhost)
spin_lock_irqsave(vhost->host->host_lock, flags);
vhost->state = IBMVFC_NO_CRQ;
vhost->logged_in = 0;
- ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_NONE);
/* Clean out the queue */
memset(crq->msgs, 0, PAGE_SIZE);
--
2.7.4
More information about the kernel-team
mailing list