[PATCH Trusty SRU] UBUNTU: [Config] CONFIG_RTC_DRV_EFI=y

Seth Forshee seth.forshee at canonical.com
Wed Oct 19 13:21:16 UTC 2016


On Tue, Oct 18, 2016 at 12:13:05PM -0600, dann frazier wrote:
> On Tue, Oct 18, 2016 at 09:25:59AM -0700, Tim Gardner wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1608854
> > 
> > This config option was inadvertently set to =m during
> > the UEFI backporting process.
> > 
> > Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> > ---
> >  debian.master/config/config.common.ubuntu | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> > index a93f97d..a1603b9 100644
> > --- a/debian.master/config/config.common.ubuntu
> > +++ b/debian.master/config/config.common.ubuntu
> > @@ -5356,7 +5356,7 @@ CONFIG_RTC_DRV_DS1672=m
> >  CONFIG_RTC_DRV_DS1742=m
> >  CONFIG_RTC_DRV_DS2404=m
> >  CONFIG_RTC_DRV_DS3234=m
> > -CONFIG_RTC_DRV_EFI=m
> > +CONFIG_RTC_DRV_EFI=y
> >  CONFIG_RTC_DRV_EM3027=m
> >  CONFIG_RTC_DRV_FM3130=m
> >  CONFIG_RTC_DRV_GENERIC=m
> 
> Thanks Tim. However, you may want to avoid setting this to =y on
> x86. Upstream later disabled that option in Kconfig because it causes
> crashes w/ some implementations. See upstream commit ea1f56504ecb.
> 
> If you want to avoid that, here's an alternate patch:

Except the commit you reference is applied to trusty and makes it so
that the option cannot be enabled on x86. And if you take your patch and
run updateconfigs you get Tim's changes. So Tim's patch is the one we
should use.

Thanks,
Seth





More information about the kernel-team mailing list