ACK: [PULL v2][Xenial] Add OpenNSL to Xenial Kernel

Seth Forshee seth.forshee at canonical.com
Wed Aug 16 19:28:41 UTC 2017


On Tue, Aug 08, 2017 at 05:06:26PM +0800, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1665783
> 
> v2: remove files without compatible license, and also doc:
>     doc/
>     examples/
>     include/opennsl/
>     include/examples/
>     Legal/LICENSE-Adv
>     OpenNSL_3.1.0.17_Release_Notes_CDP.pdf
> 
> OpenNSL: https://github.com/Broadcom-Switch/OpenNSL
> The goal is to integrate the kernel part in OpenNSL which provides an
> interface to access Broadcom switch chips.
> 
> These patches are based on rtg's previous work. OpenNSL modules will only
> be enabled in amd64 build.
> 
> Please note the version integrated at this point is v3.1.0.17 (SDK 6.4.10)
> instead of the latest one due to project requirement.

Looks well isolated from the rest of the kernel so shouldn't result in
any regressions.

One small nit, there are some links to license files on github in one of
the files which don't work, and the latter license isn't actually used
for the source anyway. This does't need to stop this from being applied,
but possibly consider fixing in a follow-on patch.

Acked-by: Seth Forshee <seth.forshee at canonical.com>




More information about the kernel-team mailing list