[PATCH 3/3] UBUNTU: SAUCE: ibmvscsis: Fix srp_transfer_data fail return code
Tim Gardner
tim.gardner at canonical.com
Tue Jan 17 18:24:32 UTC 2017
From: "Bryant G. Ly" <bgly at us.ibm.com>
BugLink: http://bugs.launchpad.net/bugs/1657194
If srp_transfer_data fails within ibmvscsis_write_pending, then
the most likely scenario is that the client timed out the op and
removed the TCE mapping. Thus it will loop forever retrying the
op that is pretty much guaranteed to fail forever. A better return
code would be EIO instead of EAGAIN.
Cc: stable at vger.kernel.org
Reported-by: Steven Royer <seroyer at linux.vnet.ibm.com>
Tested-by: Steven Royer <seroyer at linux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bgly at us.ibm.com>
Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index d9a01a2..dfe4778 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3588,7 +3588,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
1, 1);
if (rc) {
pr_err("srp_transfer_data() failed: %d\n", rc);
- return -EAGAIN;
+ return -EIO;
}
/*
* We now tell TCM to add this WRITE CDB directly into the TCM storage
--
2.7.4
More information about the kernel-team
mailing list