ACK: [Acked] [PATCH 0/3][Xenial SRU] Fix rtc irq race in kvm

Colin Ian King colin.king at canonical.com
Wed Jan 25 16:58:02 UTC 2017


On 25/01/17 16:43, Andy Whitcroft wrote:
> On Wed, Dec 14, 2016 at 04:04:18PM -0600, Seth Forshee wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1649718
>>
>> A race in kvm can cause the EOI signal for the rtc irq to be lost. When
>> this happens the guest will never see another rtc intterupt. This is
>> causing the kernel's rtc selftest to hang, resulting in an autopkgtest
>> failure for the zesty kernel.
>>
>> The following three cherry picks from upstream fix this issue.
>>
>> Thanks,
>> Seth
>>
>>
>> Joerg Roedel (3):
>>   kvm: x86: Convert ioapic->rtc_status.dest_map to a struct
>>   kvm: x86: Track irq vectors in ioapic->rtc_status.dest_map
>>   kvm: x86: Check dest_map->vector to match eoi signals for rtc
>>
>>  arch/x86/kvm/ioapic.c   | 30 +++++++++++++++++++++---------
>>  arch/x86/kvm/ioapic.h   | 17 +++++++++++++++--
>>  arch/x86/kvm/irq_comm.c |  2 +-
>>  arch/x86/kvm/lapic.c    | 14 ++++++++------
>>  arch/x86/kvm/lapic.h    |  7 +++++--
>>  5 files changed, 50 insertions(+), 20 deletions(-)
> 
> Ugg, looks sane and the failure mode is very testable in ADT.
> 
> Acked-by: Andy Whitcroft <apw at canonical.com>
> 
> -apw
> 
Thanks Seth

Acked-by: Colin Ian King <colin.king at canonical.com>





More information about the kernel-team mailing list