[Acked] [kteam-tools][PATCH] wfl/bug.py: change the way to detect when to use esm ppa
Andy Whitcroft
apw at canonical.com
Tue Sep 19 11:17:36 UTC 2017
On Fri, Sep 15, 2017 at 05:37:04PM +0800, Po-Hsu Lin wrote:
> Both Precise and Trusty HWE kernel are running on series Precise.
> Use this as a better criteria, since the old if statement does not
> work for Precise kernel, there is no package called precise.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> ---
> stable/wfl/bug.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/stable/wfl/bug.py b/stable/wfl/bug.py
> index 632cbc05..f897a139 100644
> --- a/stable/wfl/bug.py
> +++ b/stable/wfl/bug.py
> @@ -847,12 +847,12 @@ class WorkflowBug():
>
> if ppa:
> msg['pocket'] = 'ppa'
> - if s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:
> + if s.series in ['precise']:
> msg['ppa'] = 'ppa:canonical-kernel-esm/ppa'
> else:
> msg['ppa'] = 'ppa:canonical-kernel-team/ppa'
> msg['key'] = 'kernel.published.ppa.%s' % s.series
> - elif s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:
> + elif s.series in ['precise']:
> msg['pocket'] = 'ppa'
> msg['ppa'] = 'ppa:canonical-kernel-esm/proposed'
> msg['key'] = 'kernel.published.ppa.%s' % s.series
> --
Oh dear ... that is a proper brown paper bag jobbie isn't it. Looks
much saner. I suspect this should have been originally:
if s.pkg_name in ['linux-lts-trusty'] or s.series in ['precise']:
And that because s.series used to be trusty for that linux-lts-trusty
because our code was a bit mad. Anyhow, it was clearly broken before,
and likely better with this change.
Acked-by: Andy Whitcroft <apw at canonical.com>
-apw
More information about the kernel-team
mailing list