APPLIED/cmt: [PATCH] [bionic] net/mlx5e: Fix int overflow

Seth Forshee seth.forshee at canonical.com
Thu Apr 12 15:48:24 UTC 2018


On Thu, Apr 12, 2018 at 09:42:56AM +0300, Talat Batheesh wrote:
> BugLink: http://bugs.launchpad.net/bugs/1763269
> 
> When calculating difference between samples, the values
> are multiplied by 100. Large values may cause int overflow
> when multiplied (usually on first iteration).
> Fixed by forcing 100 to be of type unsigned long.
> 
> This patch exist in upstream 4.16 under net_dim.h library.
> It need to be adjusted to the 4.15 kernel code location.
> 
> Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
> Signed-off-by: Talat Batheesh <talatb at mellanox.com>

Thanks for the patch. There are couple of minor issues, which I've fixed
when applying the patch:

 - Please be sure to keep the author as the original other of the patch.

 - Please be sure to keep the full upstream provenance in place when
   backporting.

The usual way to do this is to use 'git cherry-pick -s -x -e', then
perform the backporting and change the "cherry picked from ..." line to
read "backported from ...".

With those things fixed, applied to bionic/master-next.




More information about the kernel-team mailing list