ACK/cmnt: [PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value

[Stefan Bader]

On 13.04.2018 11:54, Thadeu Lima de Souza Cascardo wrote:
> From: Heikki Krogerus <heikki.krogerus at linux.intel.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1758797
> 
> On some boards, under heavy load, the EC firmware is
> unable to complete commands even in one second. Increasing
> the command completion timeout value to five seconds.
> 
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus at linux.intel.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>

> ---

Looks safe enough. Only question would be whether this is/should go upstream at
some point.

-Stefan

>  drivers/usb/typec/ucsi/ucsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 79046fe66426..8d95b3a168d2 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -28,7 +28,7 @@
>   * difficult to estimate the time it takes for the system to process the command
>   * before it is actually passed to the PPM.
>   */
> -#define UCSI_TIMEOUT_MS		1000
> +#define UCSI_TIMEOUT_MS		5000
>  
>  /*
>   * UCSI_SWAP_TIMEOUT_MS - Timeout for role swap requests
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180413/0ecfcd4f/attachment.sig>