NAK: [xenial/gcp][bionic/gcp][cosmic/gcp][PATCH] UBUNTU: Add the linux-modules-extra-gcp/gke meta package

[Kleber Souza]

On 07/10/18 11:13, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1780923
> 
> linux-image-gcp/gke does not install extra modules by default. Because
> of that, there's no simple way for users and for the testing
> infrastructure to install them.
> 
> Add a meta package to always follow the latest
> linux-modules-extra-<version>-gcp/gke package available.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> ---
>  debian/control.d/gcp | 8 ++++++++
>  debian/control.d/gke | 8 ++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/debian/control.d/gcp b/debian/control.d/gcp
> index 1db6cd3..263b6d4 100644
> --- a/debian/control.d/gcp
> +++ b/debian/control.d/gcp
> @@ -1,3 +1,11 @@
> +Package: linux-extra at SUFFIX@

Shouldn't this be linux-modules-extra at SUFFIX@ ? There are no other
package in the repo called linux-extra*.

> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SUFFIX@

The binary package produced is called

linux-modules-extra-<kernel-abi>-gcp

So above should be

linux-modules-extra-${kernel-abi-version}@SUFFIX@


> +Description: Google Cloud Platform (GCP) Linux kernel extra modules
> + This package will always depend on the latest Google Cloud Platform (GCP)
> + extra modules package available.
> +
>  Package: linux-headers at SUFFIX@
>  Architecture: amd64
>  Section: kernel
> diff --git a/debian/control.d/gke b/debian/control.d/gke
> index 96b38d1..96aa554 100644
> --- a/debian/control.d/gke
> +++ b/debian/control.d/gke
> @@ -1,3 +1,11 @@
> +Package: linux-extra at SUFFIX@

Same here: linux-modules-extra at SUFFIX@

> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-image-extra-${kernel-abi-version}@SRCSUFFIX@

linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@


> +Description: Google Container Engine (GKE) Linux kernel extra modules
> + This package will always depend on the latest Google Container Engine (GKE)
> + extra modules package available.
> +
>  Package: linux-headers at SUFFIX@
>  Architecture: amd64
>  Section: kernel
> 


Thanks,
Kleber