ACK/cmnt: [Bionic][PATCH 0/3] BFQ fixes

[Stefan Bader]

On 30.07.2018 12:14, Jesse Sung wrote:
> On Fri, Jul 27, 2018 at 5:29 PM Kleber Souza <kleber.souza at canonical.com> wrote:
>>
>> On 07/05/18 15:24, Wen-chien Jesse Sung wrote:
>>> BugLink: https://launchpad.net/bugs/1780066
>>>
>>> Disk IO will hang some seconds after boot when using BFQ as io
>>> scheduler. This was also reported in some public MLs [1][2].
>>> The fix is already in mainline, but it's not available in 4.15.
>>>
>>> [1] https://lkml.org/lkml/2017/12/1/80
>>> [2] https://groups.google.com/forum/#!topic/bfq-iosched/nB2cVfDMSOU
>>>
>>> Chiara Bruschi (1):
>>>   block, bfq: fix occurrences of request finish method's old name
>>>
>>> Paolo Valente (2):
>>>   block, bfq: remove batches of confusing ifdefs
>>>   block, bfq: add requeue-request hook
>>>
>>>  block/bfq-iosched.c | 226 +++++++++++++++++++++++++++++---------------
>>>  1 file changed, 150 insertions(+), 76 deletions(-)
>>>
>>
>> Hi Jesse,
>>
>> The fixes look good, could you please add the SRU justification on the
>> bug report?
> 
> Hi Kleber,
> 
> SRU justification has been added. Please let me know if there's still
> something missing.

This is not really a proper SRU justification (hint: Impact/Fix/Testcase/Risk of
Regression). Patches themselves look ok to me but please complete the justification.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
> 
> Thanks,
> Jesse
> 
>>
>> Thanks.
>>
>>
>> Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180730/44538be0/attachment.sig>