ACK / APPLIED[bionic]: [PATCH][Bionic][SRU Artful] watchdog: sbsa: use 32-bit read for WCV
Seth Forshee
seth.forshee at canonical.com
Thu Mar 15 13:32:04 UTC 2018
On Tue, Mar 13, 2018 at 04:51:31PM -0600, dann frazier wrote:
> From: Jayachandran C <jnair at caviumnetworks.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1755595
>
> According to SBSA spec v3.1 section 5.3:
> All registers are 32 bits in size and should be accessed using
> 32-bit reads and writes. If an access size other than 32 bits
> is used then the results are IMPLEMENTATION DEFINED.
> [...]
> The Generic Watchdog is little-endian
>
> The current code uses readq to read the watchdog compare register
> which does a 64-bit access. This fails on ThunderX2 which does not
> implement 64-bit access to this register.
>
> Fix this by using lo_hi_readq() that does two 32-bit reads.
>
> Signed-off-by: Jayachandran C <jnair at caviumnetworks.com>
> Reviewed-by: Guenter Roeck <linux at roeck-us.net>
> Signed-off-by: Guenter Roeck <linux at roeck-us.net>
> Signed-off-by: Wim Van Sebroeck <wim at iguana.be>
> (cherry picked from commit 93ac3deb7c220cbcec032a967220a1f109d58431)
> Signed-off-by: dann frazier <dann.frazier at canonical.com>
Acked-by: Seth Forshee <seth.forshee at canonical.com>
Applied to bionic/master-next, thanks!
More information about the kernel-team
mailing list