ACK/cmt: [SRU] [B/C/D] [PATCH 0/1] UBUNTU: SAUCE: downgrade error to warning

[Khaled Elmously]

On 2019-04-20 09:41:44 , Andrea Righi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1766201
> 
> [Impact]
> 
> The integrity subsystem is still reporting error messages like this at boot:
> 
>   integrity: Unable to open file: /etc/keys/x509_evm.der (-2)
> 
> In a previous commit we have downgraded this error to warning:
> 
> https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/bionic/commit/?h=master-next&id=58441dc86d7b066a2c02079829a96035587a7066
> 
> (this fix is applied everywhere, not only in bionic)
> 
> But there's another place (security/integrity/digsig.c) that reports the same
> error message that should be also downgraded to warning for consistency.
> 
> [Test Case]
> 
> No special test case is required, errors are reported at boot if an integrity
> policy is enabled.
> 
> [Fix]
> 
> Downgrade also this error message to a warning.
> 
> [Regression Potential]
> 
> It is a one-liner that changes a printk() error message, regression potential
> is minimal.
> 
> Andrea Righi (1):
>   UBUNTU: SAUCE: integrity: downgrade error to warning
> 
>  security/integrity/digsig.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 

I think the bug should be split into 2 or 3 bugs since it talks about completely different issues. I see 3 different problems being reported in the bug: the x509 error -> warning downgrade, the vio "synthetic uevent" errors, and the "sr0 superblock" issues.

This patch looks good as far as the first issue is concerned.

Acked-by: Khalid Elmously <khalid.elmously at canonical.com>