ACK/Cmnt: [SRU] [Bionic] [PATCH 0/5] Gracefully handle ACPI battery status on Asus laptops

[Stefan Bader]

On 02.02.19 16:37, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1745032
> 
> [Impact]
> My original fix for LP: #1745032 got placed by a more general solution,
> so replace the old one with the new one.
> 
> 1) The DMI based solution got reverted, so we won't be able to SRU any
> new affected models from upstream.
> 2) Many Asus laptops are affected by this bug, DMI quirk table will be really
> unmaintainable.

I believe you say it with different words here but it might help to clarify
things if you mentioned that this set drops the DMI quirks of those laptops and
that is replaced by generic code which does not need quirks.
Additionally it adds a quirk for the AC status (makes me wonder whether that is
not as painful to keep up-to-date as the battery quirk), maybe to get back the
same coverage as before.

About the risk: past experience showed that any modification within ACPI space
might have some odd side effects but at least reporting the wrong charging state
is not as critical as say the backlight.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
> 
> [Test]
> Along with fixes in UPower, Gnome Settings Daemon and Gnome Shell, the
> user confirm the kernel fix works.
> 
> [Fix]
> Reports the power status as POWER_SUPPLY_STATUS_NOT_CHARGING, the
> userspace will handle the rest.
> 
> [Regression Potential]
> Low. It covers a corner case when "power_supply_is_system_supplied()
> && battery->rate_now == 0", other cases are unaffected.
> 
> Daniel Drake (1):
>   Revert "ACPI / battery: Add quirk for Asus GL502VSK and UX305LA"
> 
> Hans de Goede (4):
>   ACPI / AC: Remove initializer for unused ident dmi_system_id
>   ACPI / battery: Remove initializer for unused ident dmi_system_id
>   ACPI / battery: Add handling for devices which wrongly report
>     discharging state
>   ACPI / battery: Ignore AC state in handle_discharging on systems where
>     it is broken
> 
>  drivers/acpi/ac.c      |  2 +-
>  drivers/acpi/battery.c | 69 ++++++++++++++++++------------------------
>  2 files changed, 31 insertions(+), 40 deletions(-)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190204/25312834/attachment.sig>