NACK: [PATCH 1/1] e1000e: Disable runtime PM on CNP+

[Stefan Bader]

On 21.02.19 13:49, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817058
> 
> There are some new e1000e devices can only be woken up from D3 one time,
> by plugging ethernet cable. Subsequent cable plugging does set PME bit
> correctly, but it still doesn't get woken up.
> 
> Since e1000e connects to the root complex directly, we rely on ACPI to
> wake it up. In this case, the GPE from _PRW only works once and stops
> working after that. Though it appears to be a platform bug, e1000e
> maintainers confirmed that I219 does not support D3.
> 
> So disable runtime PM on CNP+ chips. We may need to disable earlier
> generations if this bug also hit older platforms.
> 
> Bugzilla: https://bugzilla.kernel.org/attachment.cgi?id=280819
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> (backported from commit f6d54c3efb41923d7e341459c2abdab09b9a7773 git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue)

This modifies behavior for certain types of HW, so I rather want to wait until
this hits upstream for real.

-Stefan
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index ce4aaa9f2163..1dd5ec1cd4f5 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -7351,7 +7351,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	e1000_print_device_info(adapter);
>  
> -	if (pci_dev_run_wake(pdev))
> +	if (pci_dev_run_wake(pdev) && hw->mac.type < e1000_pch_cnp)
>  		pm_runtime_put_noidle(&pdev->dev);
>  
>  	return 0;
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190222/3dfebea4/attachment.sig>