ACK[B/C] / NAK[D/Unstable]: [SRU][Bionic/OEM-B/Cosmic/Disco][PATCH 0/3] Add support for ALC3277 codec on new Dell edge gateways

Hui Wang hui.wang at canonical.com
Wed Jan 9 01:28:31 UTC 2019


On 2019/1/8 下午10:09, Seth Forshee wrote:
> On Fri, Dec 14, 2018 at 05:11:34PM +0800, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1807334
>>
>> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
>> for Gen1 is already merged to b/c/d kernel, and this patchset is partly
>> based on Gen1's patches. Originally Shrirang is the developer of this driver,
>> but later he had a new OEM project, then I took over the left work about this
>> driver.
>>
>> The machine driver of the Gen2 is accepted by upstream, so it is time to
>> backport it to b/c/d and oem-b kernel.
>>
>> there are 3 patches for each kernel:
>> 0001-xxx.patch is to move the gpio from codec driver to machine driver
>> 0002-xxx.patch is to add the machine driver
>> 0003-xxx.patch is to enable the Kconfig for this machine driver
>>
>> [Impact]
>> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
>> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
>> for this board, so the audio (line-out and line-in) can't work.
>>
>>
>> [Fix]
>> write a ASoC machine driver for this board, and this driver is based on
>> the existing driver kbl_rt5663_max98927.c
>>
>>
>> [Test Case]
>> play sound via line-out jack, record sound via line-in jack, all work well.
>>
>>
>> [Regression Potential]
>> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
>> the machine with the HID:10EC3277 in the BIOS can use this driver.
> Overall I think these look reasonable. Partly updates to sauce patches,
> which look reasonable to me, and a new driver which should not cause
> regressions for already supported hardware. For bionic and cosmic:
>
> Acked-by: Seth Forshee <seth.forshee at canonical.com>
>
> However, your patches don't apply to disco/master-next or
> unstable/master. Can you please supply patches for these trees? Thanks!

OK, will generate the patches for those branches.

Thanks.

>




More information about the kernel-team mailing list