ACK/Cmnt: [PATCH 0/3] [SRU][Cosmic] Fix unusable SSD on configs that have 2 SSDs

[Stefan Bader]

On 17.01.19 09:35, Anthony Wong wrote:
> From: Anthony Wong <anthony.wong at canonical.com>
> 
> [Impact]
> On Thinkpad X1 Extreme with two SSDs, if NQN in the firmware are
> identical, then only one drive can be seen. NQN is supposed to be unique
> but some Intel drives do not follow that.
> 
> [Fix]
> The device-supplied subnqn is ignored and one will be generated as if
> the field is empty.
> 
> The upstream patch conflicts with a value in 'enum nvme_quirks' that we
> added in a SAUCE patch, changed that from (1<<8) to (1<<15).
> 
> [Test]
> With this fix, both drives can be seen.
> 
> [Regression Potential]
> The fix limits to Intel 760p/Pro 7600p SSD, and the fix has been
> verified by the bug reporter.
> 
> 
> Bart Van Assche (1):
>   nvme-core: rework a NQN copying operation
> 
> James Dingwall (1):
>   nvme: introduce NVME_QUIRK_IGNORE_DEV_SUBNQN
> 
> Keith Busch (1):
>   nvme: pad fake subsys NQN vid and ssvid with zeros
> 
>  drivers/nvme/host/core.c | 18 ++++++++++--------
>  drivers/nvme/host/nvme.h |  7 ++++++-
>  drivers/nvme/host/pci.c  |  5 +++--
>  3 files changed, 19 insertions(+), 11 deletions(-)
> 

Also bug reports should be nominated for all series which will need the fix
(that might also help to not forget disco/devel ;))
Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190121/a46c0ff2/attachment-0001.sig>