[PATCH 0/2][SRU][B][D][OEM-B][OEM-OSP1-B]Sometimes touchpad detected as mouse(i2c designware fails to get adapter number)

AceLan Kao acelan.kao at canonical.com
Wed Jul 3 03:16:11 UTC 2019


BugLink: https://bugs.launchpad.net/bugs/1835150

[Impact]
I2C designware fails to get its adapter number, and this may lead to fail to access touchpad through I2C bus.
[ 6.476367] WARNING: CPU: 9 PID: 567 at /build/linux-oem-osp1-bkWHJC/linux-oem-osp1-5.0.0/drivers/i2c/i2c-core-base.c:1322 i2c_add_numbered_adapter+0x81/0x90

[Fix]
The 2 commits from v5.1-rc1 fix this issue.
   cd86d1403bb4 i2c: i2c-designware-platdrv: Always use a dynamic adapter number
   77f3381a83c2 i2c: i2c-designware-platdrv: Cleanup setting of the adapter number

[Test]
Verified on Dell machine which had this issue.

[Regression Potential]
Low, the 2 commits make it always use dynamic adapter-numbers which does not make any difference in most cases and in the one case where it does make a difference the behavior change is desirable because the old behavior caused an oops.

Hans de Goede (2):
  i2c: i2c-designware-platdrv: Cleanup setting of the adapter number
  i2c: i2c-designware-platdrv: Always use a dynamic adapter number

 drivers/i2c/busses/i2c-designware-platdrv.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.17.1




More information about the kernel-team mailing list