ACK/CMNT: [PATCH 0/2][SRU][OEM-OSP1] iwlwifi: fix FW error in SYNC CMD GEO_TX_POWER_LIMIT

Anthony Wong anthony.wong at canonical.com
Thu Jun 27 09:04:00 UTC 2019


On Thu, 27 Jun 2019 at 14:30, You-Sheng Yang <vicamo.yang at canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1834415
>
> [Impact]
> Intel Wireless-AC 9560/9462 cease to function normally with -48 rev
> firmware release.
>
> [Fix]
> Two additional changes from Intel maintained backport-iwlwifi repository
> are required to bring the two models back to normal.
>
> [Test]
> Verified on hardware 9462/9560 with fw rev 48.
>
> [Regression Potential]
> Low. These changes affects all iwlwifi supported devices that use
> firmware blob that doesn't support iwl_geo_tx_power_profiles_cmd_v1
> command. This behavior change is automatically detected, so it should
> have no effect on devices other than 9462/9560 so far.
>
> Haim Dreyfuss (1):
>   iwlwifi: Add support for SAR South Korea limitation
>
> Luca Coelho (1):
>   [BUGFIX] iwlwifi: mvm: don't use iwl_geo_tx_power_profiles_cmd_v1
>
>  drivers/net/wireless/intel/iwlwifi/fw/acpi.c  | 28 ++++++----
>  drivers/net/wireless/intel/iwlwifi/fw/acpi.h  |  5 +-
>  .../net/wireless/intel/iwlwifi/fw/api/power.h | 12 ++++
>  drivers/net/wireless/intel/iwlwifi/fw/file.h  |  3 +
>  drivers/net/wireless/intel/iwlwifi/mvm/fw.c   | 55 ++++++++++++++-----
>  drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |  1 +
>  6 files changed, 76 insertions(+), 28 deletions(-)
>
> --
> 2.21.0

The two backports look good.
Given that the corresponding firmware has already landed in
linux-firmware master, I assume these patches (or a variation of such)
will land in mainline soon.

Acked-by: Anthony Wong <anthony.wong at canonical.com>

Thanks,
Anthony



More information about the kernel-team mailing list