ACK: [D][E][SRU][PATCH 0/2] POSIX fix for ftrace test in ubuntu_kernel_selftests

Stefan Bader stefan.bader at canonical.com
Wed May 29 14:12:39 UTC 2019


On 14.05.19 12:56, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1828995
> 
> == Justification ==
> There are some non-POSIX implementations in the test script, which will
> generate some noise in the test reports like:
>   -e -n [1] Basic trace file check
>   -e [PASS]
>   -e -n [2] Basic test for tracers
>   -e [PASS]
> 
> == Fix ==
> * 4ce55a9c (selftests/ftrace: Replace \e with \033)
> * 37fb665b (selftests/ftrace: Replace echo -e with printf)
> 
> These two patches can be cherry-picked into D/E
> 
> == Test ==
> Tested on a P8 box with Disco, the patched test will print the report in
> a proper format:
>   [1] Basic trace file check	[PASS]
>   [2] Basic test for tracers	[PASS]
> 
> == Regression Potential ==
> No regression is expected. This patchset just make sure this test comply
> with POSIX standard.
> 
> Juerg Haefliger (2):
>   selftests/ftrace: Replace \e with \033
>   selftests/ftrace: Replace echo -e with printf
> 
>  tools/testing/selftests/ftrace/ftracetest | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190529/2c03cb3c/attachment.sig>


More information about the kernel-team mailing list