ACK/Cmnt: [PATCH 0/2][SRU][B/D/E/OEM-B/OEM-OSP1-B] iwlwifi: exclude GEO SAR support for 3168

[Stefan Bader]

On 18.10.19 06:33, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1846016
> 
> [Impact]
> Intel Wireless AC-3168 and some 8000 models give iwlwifi firmware error
> messages in dmesg:
> 
>   kernel: iwlwifi 0000:02:00.0: Loaded firmware version: 36.77d01142.0
>   kernel: iwlwifi 0000:02:00.0: FW error in SYNC CMD GEO_TX_POWER_LIMIT
> 
> This affect B/D/E/OEM-B/OEM-OSP1-B that with GEO_TX_POWER_LIMIT support.
> 
> [Fix]
> Two upstream patches to be SRU-ed:
> 
>   fddbfeece9c7 "iwlwifi: fw: don't send GEO_TX_POWER_LIMIT command to FW version 36"
>   12e36d98d3e5 "iwlwifi: exclude GEO SAR support for 3168"
> 
> They basically exclude unsupported firmware version for sending
> GEO_TX_POWER_LIMIT command.
> 
> [Test Case]
> Tested on a Ubuntu certified HP EliteDesk 800 G3 DM that has the same AC 3168
> wireless adapter.
> 
> [Regression Risk]
> Low. This doesn't affect the majority of iwlwifi support devices but
> those incapable of processing GEO_TX_POWER_LIMIT command in the
> firmware.
> 
> Luca Coelho (2):
>   iwlwifi: fw: don't send GEO_TX_POWER_LIMIT command to FW version 36
>   iwlwifi: exclude GEO SAR support for 3168
> 
>  drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 

Based on Timo's comment and checking current bionic/master-next it appears patch
#1 likely is already applied everywhere (to be double checked when applying).
Acking both in case its missing somewhere.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20191107/c528c5bc/attachment-0001.sig>