ACK/Cmnt: [PATCH 1/1] HID: i2c-hid: fix no irq after reset on raydium 3118

[Andrea Righi]

On Tue, Nov 26, 2019 at 01:24:29PM +0800, Kai-Heng Feng wrote:
> From: Aaron Ma <aaron.ma at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1849721
> 
> On some ThinkPad L390 some raydium 3118 touchscreen devices
> doesn't response any data after reset, but some does.
> 
> Add this ID to no irq quirk,
> then don't wait for any response alike on these touchscreens.
> All kinds of raydium 3118 devices work fine.
> 
> BugLink: https://bugs.launchpad.net/bugs/1849721
> 
> Signed-off-by: Aaron Ma <aaron.ma at canonical.com>
> Signed-off-by: Jiri Kosina <jkosina at suse.cz>
> (cherry picked from commit 0c8432236dea20a95f68fa17989ea3f8af0186a5)

There should be linux-next in the cherry picked reference, but I guess
we can add that later. Apart than that:

Acked-by: Andrea Righi <andrea.righi at canonical.com>

> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> ---
>  drivers/hid/hid-ids.h              | 1 +
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index e4d51ce20a6a..676a79fb2fb9 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -955,6 +955,7 @@
>  
>  #define I2C_VENDOR_ID_RAYDIUM		0x2386
>  #define I2C_PRODUCT_ID_RAYDIUM_4B33	0x4b33
> +#define I2C_PRODUCT_ID_RAYDIUM_3118	0x3118
>  
>  #define USB_VENDOR_ID_RAZER            0x1532
>  #define USB_DEVICE_ID_RAZER_BLADE_14   0x011D
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index d75b8a803b5a..152b451c3e8e 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -172,6 +172,8 @@ static const struct i2c_hid_quirks {
>  		I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV },
>  	{ I2C_VENDOR_ID_HANTICK, I2C_PRODUCT_ID_HANTICK_5288,
>  		I2C_HID_QUIRK_NO_IRQ_AFTER_RESET },
> +	{ I2C_VENDOR_ID_RAYDIUM, I2C_PRODUCT_ID_RAYDIUM_3118,
> +		I2C_HID_QUIRK_NO_IRQ_AFTER_RESET },
>  	{ USB_VENDOR_ID_ELAN, HID_ANY_ID,
>  		 I2C_HID_QUIRK_BOGUS_IRQ },
>  	{ 0, 0 }
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team