NAK[F]: [SRU] [F/Unstable/OEM-5.6] [PATCH 0/1] Add initial audio support for Lenovo ThinkStation P620

[Kelsey Skunberg]

NAKing this for Focal all per comments in responses. Thanks!

-Kelsey

On 2020-08-05 00:40:38 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1890317
> 
> [Impact]
> Lenovo ThinkStation P620 is equipped with two USB audio card that don't
> fully work.
> 
> [Fix]
> Give these two cards profile name, so userspace can identify them to add
> addition support.
> 
> In addition to that, disable non-working element and relax error
> handling for speaker, so there's no error left. Otherwise usb-audio
> driver will stop working completely.
> 
> [Test]
> After the patch is applied, `cat /proc/asound/cards` can show correct
> profile name for each card. No more error can be spotted from dmesg.
> 
> The audio is still not fully working yet, because it requires more work
> in userspace ALSA and PulseAudio.
> 
> [Regression Potential]
> Low. Adding profile name doesn't change any code flow.
> The only behavioral change is error handling towards "Speaker."
> Becuase it actually relaxes the error handling instead of tightening, so
> devices that don't have this issue won't be affected.
> 
> Kai-Heng Feng (1):
>   ALSA: usb-audio: Add support for Lenovo ThinkStation P620
> 
>  sound/usb/mixer.c        |  4 ++++
>  sound/usb/mixer_maps.c   |  9 +++++++++
>  sound/usb/quirks-table.h | 13 +++++++++++++
>  3 files changed, 26 insertions(+)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team