[PATCH 0/1][SRU][FOCAL][GROOVY] tcp: correct read of TFO keys on big endian systems

Colin King colin.king at canonical.com
Tue Aug 11 16:01:39 UTC 2020


From: Colin Ian King <colin.king at canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1869134

== SRU Justification Focal, Groovy ==

Running the tcp_fastopen_backup_key.sh from net in ubuntu_kernel_selftests
fails on little endian systems. This is a regression that occurred because
of commit 438ac88009bc ("net: fastopen: robustness and endianness fixes
for SipHash"). 

== Fix ==

Upstream (linux-next) fix:

  commit f19008e676366c44e9241af57f331b6c6edf9552
  Author: Jason Baron <jbaron at akamai.com>
  Date:   Mon Aug 10 13:38:39 2020 -0400

      tcp: correct read of TFO keys on big endian systems

== Test case ==

Run the kernel self tests tcp_fastopen_backup_key.sh.  Currently this fails
on the last few test cases.  With the fix the test passes.

== Regression Potential == 

This fix touches the tcp fast open code paths so it can potentially impact
TCP fast opening and perhaps the TCP opening. However, this has been tested
on big and little endian systems with the regression tests, so the
regression risk is low with this fix.

-----

Jason Baron (1):
  tcp: correct read of TFO keys on big endian systems

 include/net/tcp.h          |  2 ++
 net/ipv4/sysctl_net_ipv4.c | 16 ++++------------
 net/ipv4/tcp.c             | 16 ++++------------
 net/ipv4/tcp_fastopen.c    | 23 +++++++++++++++++++++++
 4 files changed, 33 insertions(+), 24 deletions(-)

-- 
2.27.0




More information about the kernel-team mailing list