ACK/Cmnt: [PATCH 1/1] ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control

[Stefan Bader]

On 12.08.20 10:28, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891281
> 
> The USB device (0x17aa:0x1046) that support Lenovo P620 rear panel
> line-in claim to support volume control, but it doens't seem to have an
> AMP, so when line-in volume lowers below 80, nothing gets recorded
> anymore.
> 
> Disable the volume control to workaround the issue.
> 
> Fixes: f8c11eb7da4a ("ALSA: usb-audio: Add support for Lenovo ThinkStation P620")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Link: https://lore.kernel.org/r/20200810133108.31580-1-kai.heng.feng@canonical.com
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> (cherry picked from commit 34dedd2a83b241ba6aeb290260313c65dc58660e linux-next)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

on the better-regression-potential mission: maybe I would say

The change modifies volume controls of a specific device. Potentially this could
lead to unexpected effects controlling volumes for that device.

-Stefan

>  sound/usb/mixer_maps.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> index 08eb230e2bff..7e7afd71b356 100644
> --- a/sound/usb/mixer_maps.c
> +++ b/sound/usb/mixer_maps.c
> @@ -371,6 +371,7 @@ static const struct usbmix_name_map asus_rog_map[] = {
>  };
>  
>  static const struct usbmix_name_map lenovo_p620_rear_map[] = {
> +	{ 19, NULL, 2 }, /* FU, Volume */
>  	{ 19, NULL, 12 }, /* FU, Input Gain Pad */
>  	{}
>  };
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200813/06d2822b/attachment.sig>