[SRU][G, H][PATCH 2/3] UBUNTU: SAUCE: selftests: Skip BPF seftests by default

[Kamal Mostafa]

On Tue, Dec 15, 2020 at 6:05 PM Seth Forshee <seth.forshee at canonical.com>
wrote:

> On Tue, Dec 15, 2020 at 09:51:11AM -0800, Kamal Mostafa wrote:
> > On Tue, Dec 15, 2020 at 07:52:10AM -0600, Seth Forshee wrote:
> > > On Mon, Dec 14, 2020 at 02:00:39PM -0800, Kamal Mostafa wrote:
> > > > From: Mark Brown <broonie at kernel.org>
> > > >
> > > > BugLink: https://bugs.launchpad.net/bugs/1908144
> > > >
> > > > The BPF selftests have build time dependencies on cutting edge
> versions
>

<snip>


> It builds it like this:
>
>  make -C linux/tools/testing/selftests TARGETS=bpf
>
> which is essentially the same as what the compileselftests target does.
>
> As I'm reading that code, if SKIP_TARGETS isn't already set it will
> explicitly override the value passed for TARGETS to have the bpf
> selftest removed. Based on a little experimenting with the makefile,
> that seems to be exactly what happens. Changing it to this:
>
>  make -C tools/testing/selftests TARGETS=bpf SKIP_TARGETS=
>
> leaves bpf in TARGETS.
>

Why fiddle with TARGETS and SKIP_TARGETS at all?  Note that simply this
works -- with or without the disable patch(es) in place:

    make -C tools/testing/selftests/bpf

 -Kamal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201216/00fc3181/attachment-0001.html>