[SRU][Focal][PATCH 0/1] sof driver fails and print lots of errors in the dmesg (focal)

Hui Wang hui.wang at canonical.com
Tue Feb 11 08:11:52 UTC 2020


BugLink: http://bugs.launchpad.net/bugs/1862736

In the focal kernel, we backported a commit from the stable patches,
that commit make the sof driver fail to work, and even make the system
hang randomly.

The commit we introduced is:
Author: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>
Date: Mon Nov 4 14:48:12 2019 -0800

    ASoC: SOF: topology: set trigger order for FE DAI link

    BugLink: https://bugs.launchpad.net/bugs/1858428

    [ Upstream commit 5eee2b3f60065a2530d13f28e771be48b989eb4c ]

    Set trigger order for FE DAI links to SND_SOC_DPCM_TRIGGER_POST
    to trigger the BE DAI's before the FE DAI's. This prevents the
    xruns seen on playback pipelines using the link DMA.

    Signed-off-by: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
    Link: https://lore.kernel.org/r/20191104224812.3393-3-ranjani.sridharan@linux.intel.com
    Signed-off-by: Mark Brown <broonie at kernel.org>
    Signed-off-by: Sasha Levin <sashal at kernel.org>
    Signed-off-by: Seth Forshee <seth.forshee at canonical.com>


[Impact]
Booting the focal kernel on the LENOVO X1 corbon 7th and a Dell
machine which has dmic on it, the sof driver print lots of errors
even it loaded the firmware and topology conf file correctly, and
the sof driver fails to initializaton, after booting up, we run:
aplay -l, it print out that there is no soundcard. And the system
randomly hang.

[Fix]
We backported a patch from stable kernel, that is not enough, the
submitter of that patch sent 2 patches out, the stable kernel only
integrated the 2nd one, to fix this problem, let's integrate the
1st one as well.


[Test Case]
After applied all patches, the sof driver worked well, all audio
functions worked well, and the system didn't hang randomly anymore.

[Regression Risk]
Low, these two patches fix FB/BE order issue, we should backport them
together. And I have tested the patches on a LENOVO and a Dell machine,
all worked well.

Ranjani Sridharan (1):
  ASoC: pcm: update FE/BE trigger order based on the command

 sound/soc/soc-pcm.c | 95 ++++++++++++++++++++++++++++++++-------------
 1 file changed, 68 insertions(+), 27 deletions(-)

-- 
2.17.1




More information about the kernel-team mailing list