APPLIED/CMNT [OEM-OSP1] Re: [SRU][E/OEM-B-OSP1][PATCH 0/1] Disable the SND_SOC_INTEL_SKYLAKE in the kernel config

[Hui Wang]

On 2020/2/21 下午7:37, Timo Aaltonen wrote:
> On 21.2.2020 9.46, Hui Wang wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1864061
>>
>> The sof-pci-dev and snd-soc-skl all contains the same pciid, if
>> the soc-skl is loaded ahead of sof-pci-dev, the sof driver will
>> not work anymore, in the oem project, we manually put the soc-skl
>> in the blacklist.
>>
>>  From kernel-5.4 (focal kernel), the driver soc-skl is disabled by
>> default, and there is no users report any issues on it. So let us
>> disable soc-skl in the eoan and osp1 kernel too.
>>
>> The patch for eoan kernel doesn't remove the modules because looks
>> like the abi folder are not controlled by git. This will break the
>> modulecheck, so if this patch could be merged, please help remove
>> those modules:
>> snd-soc-slk
>> snd-soc-skl-ipc
>> snd-soc-skl-ssp-clk
>>
>>
>> [Impact]
>> If soc-skl driver is loaded ahead of sof driver, the sof could
>> not work anymore, we need to blacklist the soc-skl manually
>>
>> [Fix]
>> Like the focal kernel, we disable the soc_skl driver in the kernel
>> config
>>
>>
>> [Test Case]
>> Tested on Lenovo and Dell machines which has dmic, the sof driver
>> could be loaded successfully.
>>
>> Tested on the machinces without the dmic, the legacy hda driver
>> worked well as before.
>>
>> [Regression Risk]
>> Low, Focal kernel and mainine-5.5, 5.6-rc kernel all disabled this
>> dirver; and We have not met a machine need the soc_skl driver yet;
>> and Intel claim that the sof could replace the soc_skl driver.
>>
>>
>>
>> Hui Wang (1):
>>    UBUNTU: [Config] disable SND_SOC_INTEL_SKYLAKE
>>
>>   debian.oem-osp1/abi/5.0.0-1039.44/amd64/oem-osp1.modules | 4 +---
>>   debian.oem-osp1/config/annotations                       | 6 ++++--
>>   debian.oem-osp1/config/config.common.ubuntu              | 4 ++--
>>   3 files changed, 7 insertions(+), 7 deletions(-)
> The kernel has been respun since 1039, and you seem to have typoed the
> edit of the modules file (snd-soc-skl -> snd-soc-slk), but with those
> fixed applied to osp1 oem-next.

Yeah, it should be snd-soc-skl

Thx.


>
>