APPLIED[F]: [SRU][Focal/Eoan/OEM-B-OSP1][PATCH 0/5] Fix hang issue if sof fails to load firmware

Seth Forshee seth.forshee at canonical.com
Wed Feb 26 02:42:15 UTC 2020


On Tue, Feb 25, 2020 at 08:36:10PM -0600, Seth Forshee wrote:
> On Fri, Feb 21, 2020 at 05:00:39PM +0800, Hui Wang wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1861837
> > 
> > If the sof driver fails to load the firmware, it doesn't release the
> > resource, then it make the system hang when suspending and resuming.
> > 
> > After this patchset is applied, please also apply the patchset we
> > just reverted 2 weeks ago, since this patchset is the fixing patches
> > for the patches we reverted (#1857409). If need me to resend the
> > reverted patches, I will resend them.
> > 
> > 
> > [Impact]
> > The machine hangs during suspend/resume if the sof driver fails to
> > load firmware.
> > 
> > [Fix]
> > This bug is fixed in the mainline kernel v5.6-rc1, now backported
> > those patches to ubuntu kernel
> > 
> > [Test Case]
> > sudo mv /lib/firmware/intel/sof /lib/firmware/intel/sof-bak, reboot
> > then suspend and resume, the system will not hang anymore
> > 
> > And if the sof driver load the firmware successfully, the audio
> > functions all worked well as before.
> > 
> > [Regression Risk]
> > Low, the patches are backported from upstream kernel, and I tested
> > these patches on Lenovo and Dell dmic machines.
> 
> Applied to focal/master-next, thanks!

Forgot to mention, I actually only applied patch 4 as 1-3 had already
come in from upstream stable. Patch 1 at least was not completely
identical to the upstream stable patch, so you may want to check to make
sure it does what you need (I didn't really look into how they were
different, possibly it is just comment/whitespace differences).



More information about the kernel-team mailing list