ACK/cmnt: [PATCH 0/4][SRU][B/D/E] Several Hisilicon SAS Host fixes

Kleber Souza kleber.souza at canonical.com
Tue Jan 7 11:12:57 UTC 2020


On 2019-12-26 07:51, Ike Panhc wrote:
> BugLink: https://launchpad.net/bugs/1853992
> BugLink: https://launchpad.net/bugs/1853995
> BugLink: https://launchpad.net/bugs/1853997
> BugLink: https://launchpad.net/bugs/1855952
> 
> We have several fixes for Hisilicon SAS host driver and they are clean
> cherry-picked from upstream kernel.
> 
> Patch 1 and 4 are potential NULL pointer dereference fix
> Patch 2 is recover device fix
> Patch 3 fixes that some SSD can not use
> 
> All changes limit in Hisilicon SAS driver so there is lowest regression
> risk for other platform/driver.
> 
> Luo Jiaxing (1):
>   scsi: hisi_sas: Fix out of bound at debug_I_T_nexus_reset()
> 
> Xiang Chen (3):
>   scsi: hisi_sas: Check sas_port before using it
>   scsi: hisi_sas: Fix the conflict between device gone and host reset
>   scsi: hisi_sas: Assign NCQ tag for all NCQ commands
> 
>  drivers/scsi/hisi_sas/hisi_sas.h       |  1 -
>  drivers/scsi/hisi_sas/hisi_sas_main.c  | 36 ++++++++++----------------
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  5 +++-
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  5 +++-
>  4 files changed, 22 insertions(+), 25 deletions(-)
> 

The changes look good. However, if the same patches cannot be applied to
the different trees without at least 'git am -C2' they need to be tagged
as "backported from commit ..." instead of "cherry-picked from commit ...".

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>



More information about the kernel-team mailing list