ACK: [PATCH 0/2][SRU][unstable][E] The system cannot resume from S3 if user unplugs the TB16 during suspend state

Stefan Bader stefan.bader at canonical.com
Tue Jan 7 14:41:26 UTC 2020


On 10.12.19 03:34, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1849269
> 
> [Impact]
> Unplug TBT dock during S3 and then wakes up the system leads to system
> hangs. This not only happens on Dell TB16, but also Dell WD19TB. It's
> more like a BIOS or TBT firmware issue that TBT firmware doesn't
> re-create the PCIe tunnels.
> 
> [Fix]
> Mika provides 4 patches to fix this issue, but only 2 were accepted.
> Now the reset 2 commits has been included in v5.5, so backport them
> to Ubuntu kernel.
> 
> [Test]
> Verified on Dell Precision 5530 + WD19TB
> 
> [Regression Potential]
> Low, those patches doesn't change the code path much. The final commit
> adds some checks to return failure state, and it should be safe for
> those machines which are already working well.
> 
> Mika Westerberg (2):
>   PCI: pciehp: Do not disable interrupt twice on suspend
>   PCI: pciehp: Prevent deadlock on disconnect
> 
>  drivers/pci/hotplug/pciehp.h      |  6 ++--
>  drivers/pci/hotplug/pciehp_core.c | 36 ++++++++++++++++---
>  drivers/pci/hotplug/pciehp_ctrl.c |  4 +--
>  drivers/pci/hotplug/pciehp_hpc.c  | 59 +++++++++++++++++++++++++------
>  4 files changed, 84 insertions(+), 21 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200107/edb755bf/attachment.sig>


More information about the kernel-team mailing list