NAK: [PULL] [Focal/Unstable] Add support for Realtek 8723DE wireless adapter
Seth Forshee
seth.forshee at canonical.com
Tue Jan 7 20:37:05 UTC 2020
On Tue, Dec 10, 2019 at 03:40:14PM +0800, Kai-Heng Feng wrote:
> [Impact]
> There's no in-kernel support for Realtek 8723DE, so users need to use
> out-of-tree DKMS which is not from Ubuntu archive. This has security
> implication and should be avoided. Also this provides pretty bad user
> experience.
>
> [Fix]
> Add support to Realtek 8723DE.
> All commits are cherry-picked from Realtek maintained repo:
> https://github.com/rtlwifi-linux/rtw88_8723de
> Realtek is committed to update this repo until every bits are
> upstreamed.
>
> [Test]
> With the patch series applied, 8723DE can scan and connect to APs
> succesfully. Also did some S3 smoke test, it continues to work.
>
> [Regression Potential]
> Low. The device in question was never supported, and if there's any
> regression, we can count on Realtek Wireless team, thy are now pretty
> responsive on upstream mailing list.
I'm okay with applying these, but it looks like they need a refresh.
Many of the patches are upstream in 5.5, so they should not be sauce and
should have the upstream sha1s (if they don't matche the ones from the
rtw88_8723de tree, I didn't check). Unstable has many of the patches
already, and I was hitting conflicts with the others. We should also
update the annotations with the new config options.
So let's get these refreshed, then we can apply them.
Thanks,
Seth
More information about the kernel-team
mailing list