APPLIED [OEM-OSP1-B] Re: [PATCH 0/1][SRU][B][D][E][F] Dell AIO can't adjust brightness

[Timo Aaltonen]

On 16.1.2020 15.58, Stefan Bader wrote:
> On 10.01.20 07:08, Timo Aaltonen wrote:
>> On 8.1.2020 9.59, AceLan Kao wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1858761
>>>
>>> [Impact]
>>> Found on new platforms that UART require more than 1 second to respond
>>> commands in the first 10 seconds after booted.
>>> And the first command we send to scalar is dell_uart_get_scalar_status()
>>> to tell if scalar is in charge of the backlight, and it always fails to get
>>> response because of timeout.
>>>
>>> [Fix]
>>> Adding retry and increasing read timeout for dell_uart_get_scalar_status()
>>>
>>> [Test]
>>> Verified on the target Dell AIO, it can now read the response from scalar.
>>>
>>> [Regression Potential]
>>> Low, adding retry and increasing read timeout doesn't change the code flow.
>>>
>>> AceLan Kao (1):
>>>   UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get
>>>     scalar status
>>>
>>>  drivers/platform/x86/dell-uart-backlight.c | 8 ++++++--
>>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>
>> applied to osp1 oem-next, thanks
>>
> You should not apply anything without having a bug task for it... just saying.

good point, forgot to update the status back then


-- 
t

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200116/cdee438b/attachment.sig>