[linux-firmware][SRU][B/E/F/unstable][PATCH 0/1] intel/sof: update the intel sof firmware to v1.3-0f73628 for cml and cnl

[Hui Wang]

On 2020/1/28 上午5:47, Seth Forshee wrote:
> On Wed, Jan 22, 2020 at 10:42:02AM +0800, Hui Wang wrote:
>> On 2020/1/22 上午4:27, Seth Forshee wrote:
>>> On Mon, Jan 13, 2020 at 01:11:48PM +0800, Hui Wang wrote:
>>>> BugLink: https://bugs.launchpad.net/bugs/1859387
>>>>
>>>> [Impact]
>>>> Intel released a new version sof firmware to Canonical, they suggested
>>>> that we should integrate the version v1.3-0f73628 and we should only
>>>> pick the cml and cnl firmwares since other firmwares are not fully
>>>> tested. Since we have a couple of Lenovo and Dell cnl and cml machines
>>>> which need to enable sof driver, we integrate the firmwares to
>>>> ubuntu.
>>>>
>>>> [Fix]
>>>>    - fix the hang issue in the firmware for the cml and cnl
>>>>    - introduce the ldc file which helps to do the firmware debug
>>>>    - divide the firmware to cml and cnl specific ones
>>>>
>>>>
>>>> [Test Case]
>>>> These firmwares are already widely used in oem project, the audio
>>>> functions worked very well under both Lenovo and Dell dmic machines.
>>>>
>>>> [Regression Risk]
>>>> Low, Intel released these firmware to us, and we already did large
>>>> numbers audio test in the oem project.
>>> We had some issues before with unsigned firmware files causing issues on
>>> some platforms. Is there any possibility of similar issues with these
>>> files?
>> This firmware has been tested by LENOVO and DELL dmic machines, so far there
>> is no issues found. And this firmware is not perfect, there are some
>> features missing in this version like LED support and soundwire support,
>> and I am going to submit the new firmware Feb or Mar after Intel releases a
>> new one to us, for now, the oem project push  me to submit this version
>> first.
> One more question. We recently reverted patches related to loading sof
> firmware. Is this still relevant with those patches reverted?

A little bit relevant with those patches, but it is still safe to merge 
the firmware update. Without those kernel patches, the change of "divide 
the firmware to cml and cnl specific ones" on firmware is meaningless 
now, but there are two changes (fixing hang issue and introduce ldc) we 
need.  So please merge this SRU request, it is safe even without those 
kernel patches.

And I will do more debug on those kernel patches and get those patches 
back to kernel ASAP.

Thanks,

Hui.



>
> Thanks,
> Seth