NAK[F]: [SRU][F][PATCH 1/2] (upstream) s390/qeth: fix false reporting of VNIC CHAR config failure

[Seth Forshee]

On Mon, Jan 27, 2020 at 02:09:03PM +0200, frank.heimes at canonical.com wrote:
> From: Alexandra Winter <wintera at linux.ibm.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1860523
> 
> commit 68c57bfd52836e31bff33e5e1fc64029749d2c35 upstream.
> 
> Symptom: Error message "Configuring the VNIC characteristics failed"
> in dmesg whenever an OSA interface on z15 is set online.
> 
> The VNIC characteristics get re-programmed when setting a L2 device
> online. This follows the selected 'wanted' characteristics - with the
> exception that the INVISIBLE characteristic unconditionally gets
> switched off.
> 
> For devices that don't support INVISIBLE (ie. OSA), the resulting
> IO failure raises a noisy error message
> ("Configuring the VNIC characteristics failed").
> For IQD, INVISIBLE is off by default anyways.
> 
> So don't unnecessarily special-case the INVISIBLE characteristic, and
> thereby suppress the misleading error message on OSA devices.
> 
> Fixes: caa1f0b10d18 ("s390/qeth: add VNICC enable/disable support")
> 
> OriginalAuthor: Alexandra Winter <wintera at linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera at linux.ibm.com>
> Reviewed-by: Julian Wiedmann <jwi at linux.ibm.com>
> Signed-off-by: Julian Wiedmann <jwi at linux.ibm.com>
> Signed-off-by: David S. Miller <davem at davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> (backported from commit 68c57bfd52836e31bff33e5e1fc64029749d2c35)
> [ frank-heimes: from 5.4-stable ]
> Signed-off-by: Frank Heimes <frank.heimes at canonical.com>

This has already been applied from 5.4 stable. Thanks!