APPLIED[Unstable]: [SRU][F/OEM-5.6/unstable][PATCH 00/19] ASoC/amd: add audio driver for amd renoir

Seth Forshee seth.forshee at canonical.com
Mon Jun 1 21:34:16 UTC 2020


On Mon, Jun 01, 2020 at 11:17:28AM -0500, Seth Forshee wrote:
> On Thu, May 28, 2020 at 10:10:44AM +0800, Hui Wang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1881046
> > 
> > This patchset is for mainline kernel-5.8, after backporting to 5.6,
> > there is no need to change anything, but after backporting to 5.4
> > kernel, because of API differences, need to do some change to adapt
> > to 5.4 kernel's API. So there is one more patch for focal than for
> > oem-5.6.
> > 
> > [Impact]
> > We have a couple of LENOVO machines which has amd renoir audio on
> > them, our kernel doesn't have the driver for it yet.
> > 
> > [Fix]
> > amd just upstreamed the driver, it is for kernel-5.8, we backport
> > them to ubunt kernel.
> > 
> > [Test Case]
> > boot the kernel with those patches, we could see a sound card named
> > "acp" and the dmic on it could record sound via arecord.
> > 
> > [Regression Risk]
> > Low, just adding a new driver, no change to existing drivers.
> 
> I looked at these for unstable, there are a couple of issues:
> 
>  - You didn't mark the patches as sauce, despite indicating that they
>    come from somewhere other than upstream or linux-next. However, the
>    patches are in linux-next, so you should leave them as non-sauce and
>    indicate that they came from there.
> 
>  - The config patch for unstable is against the oem tree, and thus does
>    not apply to unstable.
> 
> Please correct these issues and resubmit.

Hmm, well it seems I forgot to drop these from my tree when I was
applying patches, and I pushed them and prepared an upload before I
remembered. The config patch I had already fixed, but I had not updated
the provenance. Oh well, they will get dropped on the rebase to 5.8
anyhow.

I guess you got lucky this time, please pay more attention to these
things in the future.

Seth



More information about the kernel-team mailing list