APPLIED [OEM-5.6] Re: [SRU] [F/Unstable/OEM-OSP1-B/OEM-5.6] [PATCH 0/1] Fix incorrect speed/duplex when I210 device is runtime suspended

Timo Aaltonen tjaalton at ubuntu.com
Fri Jun 12 08:30:44 UTC 2020


On 26.5.2020 10.16, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1880656
> 
> [Impact]
> When I210 device is runtime suspended, trying to read speed or duplex from
> sysfs causes an error:
> [ 385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost
> 
> [Fix]
> Only try to read the device register when it's not runtime suspended.
> 
> [Test]
> Without the fix:
> $ cat /sys/class/net/enp3s0/speed
> 1000
> 
> With the fix:
> $ cat /sys/class/net/enp3s0/speed
> -1
> 
> -1 means "unknown speed", which is the correct status when device is runtime
> suspend.
> 
> [Regression Potential]
> Low. It's a trivial fix which limits to one driver.
> 
> Kai-Heng Feng (1):
>   igb: Report speed and duplex as unknown when device is runtime
>     suspended
> 
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

applied to oem-5.6-next, thanks.


-- 
t



More information about the kernel-team mailing list