ACK: [SRU][B][linux-firmware v2 0/1] generate the symbollink of sof-hda-generic-2ch/4ch.tplg for bionic

[You-Sheng Yang]

Pretty confusing here because I had applied the patch, built binary and
used it to upgrade without error. What's wrong actually?

You-Sheng Yang

Seth Forshee <seth.forshee at canonical.com> 於 2020年6月15日 週一 23:35 寫道：

> On Wed, Jun 10, 2020 at 09:21:45AM +0800, Hui Wang wrote:
> > Hi Vicamo,
> >
> > Did you try the original SRU patch? If I don't change the WHENCE.ubuntu,
> > just use the sof-tplg/*.tplg as before, there is no error when building
> and
> > all files and symbollinks are in position too. Maybe bionic
> linux-firmware
> > could support *.tplg?
>
> bionic isn't using WHENCE* for installing firmware files, that was a
> relatively recent change upstream.
>
> >
> > Thanks,
> >
> > Hui.
> >
> > On 2020/6/5 上午10:53, You-Sheng Yang wrote:
> > > Applied locally and built binary for tests. No error in package
> upgrade,
> > > and all files are in position.
> > >
> > > Acked-by: You-Sheng Yang <vicamo.yang at canonical.com>
> > >
> > > On 2020-06-04 19:16, Hui Wang wrote:
> > > > BugLink: https://bugs.launchpad.net/bugs/1880623
> > > >
> > > > In the v2:
> > > > Changed the WHENCE.ubuntu. in the past, we wrote *.ri/*.tplg,
> > > > for sof-firmware, now write full file/link names.
> > > >
> > > > [Impact]
> > > > Users install the focal kernel on the bionic, the sof driver
> > > > in focal kernel will fail to load the tplg files.
> > > >
> > > > [Fix]
> > > > generate the symbollinks according to the requirement of sof driver
> > > > in the focal kernel.
> > > >
> > > > [Test Case]
> > > > booting the focal kernel on bionic, the sof driver could
> > > > load the tplg successfully, and the audio works well.
> > > >
> > > > [Regression Risk]
> > > > Low, the bionic kernel will still load sof-hda-generic.tplg,
> > > > there is no any impact on the original bionic kernel +
> linux-firmware.
> > > >
> > > >
> > > > Hui Wang (1):
> > > >    UBUNTU: SAUCE: generate 2 symbollinks for sof-hda-generic.tplg
> > > >
> > > >   WHENCE.ubuntu                           | 16 +++++++++++++---
> > > >   intel/sof-tplg/sof-hda-generic-2ch.tplg |  1 +
> > > >   intel/sof-tplg/sof-hda-generic-4ch.tplg |  1 +
> > > >   3 files changed, 15 insertions(+), 3 deletions(-)
> > > >   create mode 120000 intel/sof-tplg/sof-hda-generic-2ch.tplg
> > > >   create mode 120000 intel/sof-tplg/sof-hda-generic-4ch.tplg
> > > >
> > >
>
> > --
> > kernel-team mailing list
> > kernel-team at lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200615/908108a7/attachment-0001.html>