[NACK] [PATCH bionic] UBUNTU: SAUCE: wireguard: add dkms to build so module gets signed

[Andy Whitcroft]

On Fri, Jun 19, 2020 at 01:31:42AM -0600, Jason A. Donenfeld wrote:
> Now that wireguard-dkms has been put into Bionic's -proposed, and soon
> to -updates, we can properly put wireguard.ko into the Bionic kernel in
> the nicely signed version that users have on Focal and Eoan. Because
> everybody is very busy due to recent security things, according to
> apw@, I figured it'd be easiest to just attempt to do this myself.
> 
> Now, I'm not a Canonical kernel maintainer and these scripts aren't
> mine, but I still tried my hardest to copy the patterns used in the
> Focal kernel, while updating it for the subtle macro differences used by
> the Bionic kernel.
> 
> In my testing, this appears to work very well, though I temporarily had
> to change ~18.04.1 to ~20.04.1 in the dkms-versions file, because the
> new 18.04.1 one doesn't appear to have propagated to the archives yet.
> But as the package moves from -proposed to -updates, I expect that issue
> to go away pretty soon on its own. Beyond that, this appears to have
> worked entirely as planned, and the resulting deb arrived with a fully
> functional wireguard.ko.
> 
> So, hopefully you can take this patch as-is, and it won't require
> further delay or hassle. If not as-is, at the very least this should
> require very minimal tweeking from code owners.
> 
> That way, a signed wireguard.ko is able to be shipped with Bionic for
> the June 29 kernel update and not be delayed for another month.

This looks pretty close for bionic:linux, Nacking in favour of a tested
series which includes the bionic:linux-meta changes needed to bring the
provides infrastructure that the wireguard package relies on.

-apw