ACK: [SRU][F][PATCH 0/2] Upstream fix for i915_active_acquire crash

Andrea Righi andrea.righi at canonical.com
Thu May 14 09:35:01 UTC 2020


On Wed, May 13, 2020 at 11:10:47AM -0700, Sultan Alsawaf wrote:
> BugLink: https://bugs.launchpad.net/bugs/1868551
> 
> SRU Justification:
> 
> [Impact]
> Users are experiencing a frequent NULL pointer dereference crash in
> i915_active_acquire when using kms, which is used by default.
> 
> [Fix]
> The fix is a cherry pick from upstream which was supposed to be backported to
> 5.4 by upstream, but was neglected. The fix has a subsequent Fixes patch to
> resolve some uninitialized pointer usage.
> 
> [Test]
> Verified by multiple bug reporters.
> 
> [Regression Potential]
> Low. Although there are a lot of lines added, they're mostly boilerplate, and
> this patch is confirmed by multiple users to fix a crash.

Looks good to me.

Acked-by: Andrea Righi <andrea.righi at canonical.com>



More information about the kernel-team mailing list