[SRU][Xenial][PATCH 1/1] ext2: fix debug reference to ext2_xattr_cache
Ian May
ian.may at canonical.com
Fri May 22 21:15:52 UTC 2020
From: Jan Kara <jack at suse.cz>
BugLink: https://bugs.launchpad.net/bugs/1880213
Fix a debug-only build error in ext2/xattr.c:
When building without extra debugging, (and with another patch that uses
no_printk() instead of <empty> for the ext2-xattr debug-print macros,
this build error happens:
../fs/ext2/xattr.c: In function ‘ext2_xattr_cache_insert’:
../fs/ext2/xattr.c:869:18: error: ‘ext2_xattr_cache’ undeclared (first use in
this function); did you mean ‘ext2_xattr_list’?
atomic_read(&ext2_xattr_cache->c_entry_count));
Fix the problem by removing cached entry count from the debug message
since otherwise we'd have to export the mbcache structure just for that.
Fixes: be0726d33cb8 ("ext2: convert to mbcache2")
Reported-by: Randy Dunlap <rdunlap at infradead.org>
Signed-off-by: Jan Kara <jack at suse.cz>
(cherry picked from commit 32302085a8d90859c40cf1a5e8313f575d06ec75)
Signed-off-by: Ian May <ian.may at canonical.com>
---
fs/ext2/xattr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 7cf2d15cd370..798acc530d66 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -824,8 +824,7 @@ ext2_xattr_cache_insert(struct mb_cache *cache, struct buffer_head *bh)
error = mb_cache_entry_create(cache, GFP_NOFS, hash, bh->b_blocknr, 1);
if (error) {
if (error == -EBUSY) {
- ea_bdebug(bh, "already in cache (%d cache entries)",
- atomic_read(&ext2_xattr_cache->c_entry_count));
+ ea_bdebug(bh, "already in cache");
error = 0;
}
} else
--
2.25.1
More information about the kernel-team
mailing list