[Xenial][PATCH] UBUNTU: SAUCE: Revert: Revert "ACPI / LPSS: allow to use specific PM domain during ->probe()"

Wen-chien Jesse Sung jesse.sung at canonical.com
Thu May 28 13:19:09 UTC 2020


BugLink: https://launchpad.net/bugs/1881124

I2C bus on Dell Edge Gateway stops working after commit
Revert "ACPI / LPSS: allow to use specific PM domain during ->probe()"
with error messages like:

[ 13.812210] i2c_designware 80860F41:01: Unknown Synopsys component type: 0x00000000
[ 13.855837] i2c_designware 80860F41:01: timeout in enabling adapter
[ 14.856276] i2c_designware 80860F41:01: controller timed out
[ 14.856288] i2c_designware 80860F41:01: Unknown Synopsys component type: 0x00000000

Revert the commit for now until we figure out what is really causing
the problem.

Signed-off-by: Wen-chien Jesse Sung <jesse.sung at canonical.com>
---
 drivers/acpi/acpi_lpss.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 65e7b3133fbc..3ae8001ddaf1 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -834,13 +834,8 @@ static int acpi_lpss_platform_notify(struct notifier_block *nb,
 	}
 
 	switch (action) {
-	case BUS_NOTIFY_BOUND_DRIVER:
-		pdev->dev.pm_domain = &acpi_lpss_pm_domain;
-		break;
-	case BUS_NOTIFY_UNBOUND_DRIVER:
-		pdev->dev.pm_domain = NULL;
-		break;
 	case BUS_NOTIFY_ADD_DEVICE:
+		pdev->dev.pm_domain = &acpi_lpss_pm_domain;
 		if (pdata->dev_desc->flags & LPSS_LTR)
 			return sysfs_create_group(&pdev->dev.kobj,
 						  &lpss_attr_group);
@@ -848,6 +843,7 @@ static int acpi_lpss_platform_notify(struct notifier_block *nb,
 	case BUS_NOTIFY_DEL_DEVICE:
 		if (pdata->dev_desc->flags & LPSS_LTR)
 			sysfs_remove_group(&pdev->dev.kobj, &lpss_attr_group);
+		pdev->dev.pm_domain = NULL;
 		break;
 	default:
 		break;
-- 
2.25.1




More information about the kernel-team mailing list