ACK/Cmnt: [SRU][F:linux-bluefield][PATCH 0/3] TLS Fixes

[Stefan Bader]

On 05.04.21 17:33, Daniel Jurgens wrote:
> SRU Justification:
> 
> [Impact]
> 
> * TLS offloads don't work on the ARM.
> 
> [Fix]
> 
> * Enable offloads via backport from newer upstream kernel.
> 
> [Test Case]
> 
> * TLS offloads traffic test on the ARM using seperate host mode, or a subfunction.
> 
> [Regression Potential]
> 
> * The regression can be considered as low, since:
> * The code is well tested, and it applies cleanly.
> 
> Boris Pismenny (1):
>    net/tls: Add asynchronous resync
> 
> Colin Ian King (1):
>    net/tls: fix sign extension issue when left shifting u16 value
> 
> Tariq Toukan (1):
>    net/tls: Fix wrong record sn in async mode of device resync
> 
>   include/net/tls.h    | 52 +++++++++++++++++++++++++++++++++++++++-
>   net/tls/tls_device.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 119 insertions(+), 1 deletion(-)
> 
Hi Daniel,

just some additional notes on the bug report in general and the SRU 
justification in particular:

* I added you as assignee for the Focal task since you are the one
   who submitted the patches (/ who is driving this)
* The justification is best placed into the description as this always
   remains the first thing anyone sees when opening the report. You can
   edit this anytime by clicking on the little yellow ball icon in the
   upper right corner of the bug description box. In this case it is
   the first comment of the bug report, so it does not matter. But if
   there has been some discussion new comments end up very far away
   from the top.
  * The regression potential is probably a bit ambiguous: the intention
    is not to say how likely there is a regression but what might be the
    visible effects if one happens. In a way some hinting/help for those
    running the verification tests on the kernels which contain the
    changes. In some way related to the test case/plan.

Above would be for consideration for future submissions (actually an additional 
argument to put the justification into the description is that this can be 
updated, comments cannot). For the submission:

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210408/f5b619b9/attachment.sig>