ACK/Cmnt: [PATCH 0/3][FGH:linux-azure] Enforce CONFIG_ACPI_HOTPLUG_MEMORY annotation

[Stefan Bader]

On 20.04.21 16:32, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1671203
> 
> [Impact]
> 
> These patches have no run time impact. There has recently been a request
> to enable CONFIG_ACPI_HOTPLUG_MEMORY in focal:linux-kvm. I noticed
> that all other cloud kernels have this config enabled except for
> linux-azure, which MSFT specifically asked to have disabled. In an
> effort to forestall homegenization of all cloud kernel settings, I've added
> this annotation to remember why CONFIG_ACPI_HOTPLUG_MEMORY is not enabled.
> 
> [Test Plan]
> 
> cranky updateconfigs -c
> 
> [Where problems could occur]
> 
> There is no run time imaact.
> 
> [Other Info]
> 
> 
> 
This raises a bit of a dilemma for me. On one side I can understand that a bug 
reference is added because that is what SRU patches normally do. But at the same 
time this is hidden from the changelog which makes sense since it is just 
touching the annotations in a way that does not change the build at all.
I think in that special case I would derive from the rule of adding a bug 
reference. Even more so since the bug that is referred to is not matching the 
source and is about something only loosely related and already released. The 
reasoning is part of the commit message so having an unrelated bug reference 
feels like rather causing confusion here.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210421/b9339adb/attachment.sig>