ACK/Cmnt: [PATCH 1/1][SRU][OEM-5.10/H/U] ALSA: hda/cirrus: Set Initial DMIC volume for Bullseye to -26 dB

[Stefan Bader]

On 27.04.21 07:59, You-Sheng Yang wrote:
> From: Stefan Binding <sbinding at opensource.cirrus.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1923557
> 
> After booting for first time on Bullseye, the DMIC is currently muted.
> Instead, the DMIC volume should be set to a valid initial value.
> 
> Tested on DELL Inspiron-3505, DELL Inspiron-3501, DELL Inspiron-3500
> 
> Signed-off-by: Stefan Binding <sbinding at opensource.cirrus.com>
> Signed-off-by: Vitaly Rodionov <vitalyr at opensource.cirrus.com>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1923557
> Reported-and-tested-by: You-Sheng Yang <vicamo.yang at canonical.com>
> Cc: <stable at vger.kernel.org>
> Link: https://lore.kernel.org/r/20210426163749.196153-2-vitalyr@opensource.cirrus.com
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
(backported from commit 0e853a9c3937caa9f13fdde547d6202f92457c2b linux-next)
> Signed-off-by: You-Sheng Yang <vicamo.yang at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

The patch now is in linux-next. If this gets applied, we have to double check 
whether it even got into upstream. But either way the SAUCE tag can be dropped 
and the backported line should be adjusted.

-Stefan

>   sound/pci/hda/patch_cirrus.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
> index 5e938ab2bde3..075a2454b83b 100644
> --- a/sound/pci/hda/patch_cirrus.c
> +++ b/sound/pci/hda/patch_cirrus.c
> @@ -2182,6 +2182,11 @@ static int cs8409_cs42l42_fixup(struct hda_codec *codec)
>   	if (err < 0)
>   		return err;
>   
> +	/* Set initial volume on Bullseye to -26 dB */
> +	if (codec->fixup_id == CS8409_BULLSEYE)
> +		snd_hda_codec_amp_init_stereo(codec, CS8409_CS42L42_DMIC_ADC_PIN_NID,
> +				HDA_INPUT, 0, 0xff, 0x19);
> +
>   	if (!snd_hda_gen_add_kctl(
>   			&spec->gen, NULL, &cs8409_cs42l42_hp_volume_mixer))
>   		return -1;
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210429/e362c5d1/attachment.sig>