ACK/Cmnt: [SRU][PATCH v2 0/1][G/aws, F/aws, B/aws, X/aws] aws: properly

[Stefan Bader]

On 01.02.21 15:29, Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1913739
> 
> [Impact]
> 
> To properly support instance types in AWS with > 255 cores we need to
> make sure that commit c40aaaac1018ff1382f2d35df5129a6bcea3df6b
> ("iommu/vt-d: Gracefully handle DMAR units with no supported address widths")
> is applied across all our linux-aws kernels.
> 
> [Test Case]
> 
> Tests performed by AWS.
> 
> [Fix]
> 
> Apply/backport commit c40aaaac1018ff1382f2d35df5129a6bcea3df6b.
> 
> [Regression potential]
> 
> The fix is affecting only intel IOMMU and it is an upstream fix, so the
> regression potential should be minimal.
> 
> Changes v1 -> v2:
>  - include patches for G/aws and X/aws
> 
> 
The cherry pick seems plausible and the backports matching the  cherry pick (a
short hint about what had to change would be nice).

The bug report lacked consistency in status and importance settings (and what
about Hirsute? Assuming it does not yet exist separately then its invalid.
Also the "regression potential" is not quite right. It should say what a
possible regression would look like, not how likely it is thought to be.

The patches themselves are ok, so

Acked-by: Stefan Bader <stefan.bader at canonical.com>

But you should fix up the bug report.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210202/bb35c6fa/attachment.sig>