ACK+Cmnt: [focal:linux-azure][(additional) PATCH 0/1] LP:#1911438 - CIFS: Request for backport

[Thadeu Lima de Souza Cascardo]

On Tue, Feb 02, 2021 at 02:39:49PM -0300, Marcelo Henrique Cerri wrote:
> BugLink: https://bugs.launchpad.net/bugs/1911438
> 
> Microsoft is asking for an additional commit in this bug and since it
> wasn't released yet I'm "amending" this additional commit. Sorry for
> the heterodox approach :-)
> 
> This additional commit is also in stable (in version v5.4.93) and it
> will also eventually make into the generic kernels. As the previous
> patches we are just targeting the azure kernel first.
> 

Given this is a followup for a reported issue, what specific test for
verification has been done? I am not talking about regressions here, and the
whole point of the Test Case section of the SRU template is to give whoever
will do verification on how to test for the specific issue that is being fixed.

I am giving my ACK here as this is a clean upstream cherry pick and has been
picked as a stable fix too. But we should rather be able to test for the issue
if possible.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>

> As the previous patches this one was also smoke tested as the bug
> description.
> 
> Bug description:
> 
> [Impact]
> 
> Microsoft CIFS team requested below patches to be backported (it was marked for stable last month) to Ubuntu 18.04 and newer.
> 
> 6988a619f5b7 "cifs: allow syscalls to be restarted in __smb_send_rqst()"
> 2659d3bff3e1 "cifs: fix interrupted close commands"
> 214a5ea081e7 "cifs: do not fail __smb_send_rqst if non-fatal signals are pending"
> 
> Since 6988a619f5b79e4efadea6e19dcfe75fbcd350b5 hasn't been picked up for 5.4.0-1031-azure (the current 18.04 kernel version for Azure image), I would like make a request for backport.
> 
> [Test Case]
> 
> Since those are small improvements a basic smoke test can be used to avoid regressions:
> 
> 1. Install cifs-utils and dbench:
> 
>   $ sudo apt-get install cifs-utils dbench
> 
> 2. Mount a CIFS share using:
> 
>    $ sudo mount -t cifs -o username=REMOTEUSER \\remoteip\path\to\shared\folder /mnt
> 
> 3. Run dbench and check for regressions:
> 
>    $ cd /mnt; dbench 20 -t 120 -D .
> 
> [Where problems could occur]
> 
> The regression potential is restricted to the ability of mounting and accessing CIFS volumes.
> 
> ---
> Ronnie Sahlberg (1):
>   cifs: do not fail __smb_send_rqst if non-fatal signals are pending
> 
>  fs/cifs/transport.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team